[Bug 585138] Review Request: python-hwdata - Python bindings to hwdata package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585138

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org
               Flag|                            |fedora-review+

--- Comment #2 from Thomas Spura <tomspur at fedoraproject.org> 2010-04-23 15:01:24 EDT ---
Review:

Good:
- name ok
- BR/R ok
- %install ok
- %clean there
- noarch ok
- no libs
- no .la
- license ok GPLv2
- sources match upstream: 531508df9067f13f7494e6b5bd3df474
- builds in koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=2133544
- rpmlint ok
  $rpmlint ./python-hwdata-1.0-1.fc13.src.rpm
noarch/python-hwdata-1.0-1.fc13.noarch.rpm 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.


Needswork:
- %files partly ok
  What do you mean with %doc html*?
  Do you want %doc html or %doc html/* ?
  But either way not what you wrote above...
- url partly ok / it's part of the spacewalk software, but there isn't this
package menioned or didn't I found it on the first sight?
  It's even not on:
  http://spacewalk.redhat.com/yum/0.8/Fedora/12/i386/
  Or is this version to new to be there?


#############################################################################

Fixing the URL/setting up a upstream section explainging this python snipped
and %doc should not be a problem...

#############################################################################

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.