[Bug 584111] Review Request: cmatrix - Simulate the display from "The Matrix"

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=584111

--- Comment #8 from ayush.hakmn at gmail.com 2010-04-25 14:57:30 EDT ---
(In reply to comment #7)
> Be sure to go through the Fedora guidelines, most importantly of which
>  http://fedoraproject.org/wiki/Packaging/Guidelines
>  http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
> Additionally to the Packaging Guidelines, there are a bunch of language /
> application specific guidelines that are linked to in the Packaging Guidelines.
> 
> Here are some tricks of the trade:
> http://fedoraproject.org/wiki/Packaging_tricks
> http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
> http://fedoraproject.org/wiki/Common_Rpmlint_issues
> 
> 
> **
> 
> Notes:
> 
> - increment the release every time you make changes to the spec file, also
> during the review process. This makes it easier for others to see what has been
> done.
> 
> - your changelog does not adhere to the changelog format, you need to add the
> release. (See packaging guidelines) Also, add an empty line inbetween different
> changelog entries.
> 
> - Use
>  make %{?_smp_mflags}
> instead of
>  make
> to enable SMP build.
> 
> - Drop explicit Requires: ncurses. This is automatically picked up by rpm.
> 
> - I suggest changing Source: to Source0.
> 
> - Use %{version} macro in source line, i.e.
>  http://www.asty.org/cmatrix/dist/cmatrix-1.2a.tar.gz
> should be
>  http://www.asty.org/cmatrix/dist/cmatrix-%{version}.tar.gz
> 
> - Don't duplicate the name in the summary. The summary should be:
>  Simulate the display from "The Matrix"    

Thanks Jussi for the comments.
I'd edited the spec file as commented by you & included rpmlint output in
another file .
SRPM URL : http://hakmn.fedorapeople.org/cmatrix-1.2a-2.src.rpm
SPEC URL : http://hakmn.fedorapeople.org/cmatrix.spec
RPMLINT o/p URL : http://hakmn.fedorapeople.org/rpmlint-cmatrix

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.