[Bug 585719] Review Request: wxformbuilder - The OpenSource wxWidgets Designer, GUI Builder, and RAD Tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585719

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-04-25 16:18:35 EDT ---
Just a few comments:

- You need to write in the specfile, how you got the sources and not 'I did 
  something and here they are'.

  e.g. there is a nice snipped /usr/bin/fedora-getsvn, maybe that's the easiest 
  way:
  'fedora-getsvn wxformbuilder $URL-TOSVN $REV'


- You could do %{__mkdir} -p
%{buildroot}%{_datadir}/icons/hicolor/48x48/mimetypes
  Instead all the mkdirs above

- You should not use a vendor tag:
 
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.