[Bug 585518] Review Request: gtranslator - Gettext po file editor for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585518

--- Comment #1 from Gianluca Sforna <giallu at gmail.com> 2010-04-25 16:57:42 EDT ---
There are few things to check before I can approve this.

* Fix License in the spec. Some files have an updated license (GPLV3+)

* Missing require hicolor-icon-theme. Icons changed location in the newer
release, now they live in /usr/share/icons/hicolor/*/apps/ which is not owned
by this package.

rpmlint is not silent:
$ rpmlint /var/lib/mock/fedora-13-i386/result/*.rpm
gtranslator.i686: W: spelling-error Summary(en_US) Gettext -> Get text,
Get-text, Getting
gtranslator.i686: W: spelling-error Summary(en_US) po -> PO, pew, op
gtranslator.i686: W: spelling-error %description -l en_US gettext -> get text,
get-text, getting
gtranslator.i686: W: spelling-error %description -l en_US po -> PO, pew, op
gtranslator.i686: W: file-not-utf8
/usr/share/doc/gtranslator-1.9.10/README.UMTF
gtranslator.i686: W: non-conffile-in-etc /etc/gconf/schemas/gtranslator.schemas
gtranslator.src: W: spelling-error Summary(en_US) Gettext -> Get text,
Get-text, Getting
gtranslator.src: W: spelling-error Summary(en_US) po -> PO, pew, op
gtranslator.src: W: spelling-error %description -l en_US gettext -> get text,
get-text, getting
gtranslator.src: W: spelling-error %description -l en_US po -> PO, pew, op
gtranslator-devel.i686: W: no-documentation


I think we can fix the file-not-utf8
/usr/share/doc/gtranslator-1.9.10/README.UMTF (run iconv on it) and ignore the
rest.

Other than this the package looks fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.