[Bug 582314] Review Request: libsysactivity - Lib for retrieving statistics of the system`s activity

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 26 16:23:56 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=582314

Carlos Olmedo Escobar <carlos.olmedo.e at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos.olmedo.e at gmail.com

--- Comment #11 from Carlos Olmedo Escobar <carlos.olmedo.e at gmail.com> 2010-04-26 12:23:50 EDT ---
(In reply to comment #1)
> Rpmlint: ok (no devel docs)
> Package and SPEC name: ok, upstream ships it with lib prefix
> License: ok
> Upstream source code: ok (966ba9884964803509122cb2fc6f9611 
> libsysactivity-0.5.1.tar.gz)
> Package builds: ok, see scratch build + tested locally
> ldconfig: ok
> BuildRequires: ok
> Devel split: ok
> No libtools archives: ok
> 
> Just a few notes - please fix summary - use "Library" instead of just "Lib" -
> looks better (can be fixed later in CVS) and the hardcoded lib in
> CMakeLists.txt should be fixed upstream. But works correctly.
> 
> APPROVED    

Hi. I'm the author of libsysactivity. You say that there is something wrong in
the CMakeLists.txt (which one?). Please, tell me what is it and why so i can
fix it for the next release.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list