[Bug 585467] Review Request: mozilla-googlesharing - Anonymizing proxy service for google sharing system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585467

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?

--- Comment #5 from Parag AN(पराग) <panemade at gmail.com> 2010-04-28 00:06:52 EDT ---
1) use %global over %define. See
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

2) you should take reference from
http://cvs.fedoraproject.org/viewvc/devel/mozilla-noscript/mozilla-noscript.spec?view=markup

you should write  "Requires:       mozilla-filesystem" and not BuildRequires.

3) If you want to follow macro style usage then write macro for rm command
also.
Complete macro listing you can find on your system in file 
/usr/lib/rpm/macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.