[Bug 561470] Review Request: beakerlib - shell-level integration testing library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561470

--- Comment #21 from Petr Muller <pmuller at redhat.com> 2010-04-29 10:14:55 EDT ---
Thanks for your points!

(In reply to comment #19)
> Some pedantic stuff:
> 
>  o why start release with 0 and not 1?
Well, I tend to start everything from zero :) I will keep that in mind for the
next time

>  o remove trailing ; here: 
>    %clean
>    rm -rf $RPM_BUILD_ROOT;
done

>  o add a comment why %build is empty
added

>  o use INSTALL='install -p' in make install to preserve timestamps
fix'd

>  o it's very common to have documentation in %{_docdir}/%{name}-%{version},
>    any reason not the follow that?    
I've changed Makefiles and specfile to follow that.


(In reply to comment #20)
> Petr: Can you address the questions in comment #19?
> 
> I can look at reviewing this formally and sponsoring you after that...    

Sorry for the delay, I was travelling and I avoided computer stuff for a while
:)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.