[Bug 225250] Merge Review: antlr

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225250

--- Comment #14 from Jon Ciesla <limb at jcomserv.net> 2010-04-29 10:21:57 EDT ---
Ok, fresh review:

[limb at paguroidea SPECS]$ rpmlint -i ../SRPMS/antlr-2.7.7-9.fc12.src.rpm 
antlr.src: W: spelling-error Summary(en_US) ANother -> Another, Anther, An
other
The value of this tag appears to be misspelled. Please double-check.

antlr.src: W: spelling-error %description -l en_US recognizers -> recognizer,
recognizes, recognize rs
The value of this tag appears to be misspelled. Please double-check.

antlr.src: W: spelling-error %description -l en_US parsers -> parser, parses,
parers
The value of this tag appears to be misspelled. Please double-check.

antlr.src: W: invalid-url Source0: antlr-2.7.7-RHCLEAN.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 0 errors, 4 warnings.


The spelling errors are fine, but I'd like to see an explanation as to why the
tarball was modified and what steps were taken.  Ideally, the comments should
contain exact instructions for deriving this tarball from upstream.

[limb at paguroidea SPECS]$ rpmlint -i ../RPMS/*/antlr*
antlr-C++.i686: W: spelling-error Summary(en_US) parsers -> parser, parses,
parers
The value of this tag appears to be misspelled. Please double-check.

antlr-C++.i686: W: spelling-error %description -l en_US parsers -> parser,
parses, parers
The value of this tag appears to be misspelled. Please double-check.

antlr-C++.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/ANTLRUtil.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CharInputBuffer.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/NoViableAltException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CommonAST.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CharScanner.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/IOException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CommonASTWithHiddenTokens.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenStreamRetryException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TreeParserSharedInputState.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CircularQueue.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenBuffer.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenStreamRecognitionException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/LLkParser.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/NoViableAltForCharException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenStreamRewriteEngine.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/BaseAST.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package /usr/lib/libantlr.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenStreamHiddenTokenFilter.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/LexerSharedInputState.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/ASTRefCount.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CommonHiddenStreamToken.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/RecognitionException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CharStreamIOException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/BitSet.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenStreamSelector.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenStreamIOException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/RefCount.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenStreamException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/AST.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenRefCount.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CharBuffer.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TreeParser.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/SemanticException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/InputBuffer.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/ASTArray.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/String.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenStreamBasicFilter.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/Parser.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/ASTFactory.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/ANTLRException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/config.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CommonToken.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/ASTPair.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/MismatchedCharException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenStream.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/CharStreamException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/ParserSharedInputState.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/TokenWithIndex.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package /usr/include/antlr/Token.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/ASTNULLType.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-C++.i686: W: devel-file-in-non-devel-package
/usr/include/antlr/MismatchedTokenException.hpp
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

antlr-javadoc.noarch: W: dangerous-command-in-%post rm
antlr-javadoc.noarch: W: dangerous-command-in-%postun rm
antlr-manual.noarch: E: world-writable
/usr/share/doc/antlr-manual-2.7.7/Makefile 0666
A file or directory in the package is installed with world writable
permissions, which is most likely a security issue.

antlr-manual.noarch: W: spurious-executable-perm
/usr/share/doc/antlr-manual-2.7.7/Makefile.in
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

antlr-manual.noarch: W: spurious-executable-perm
/usr/share/doc/antlr-manual-2.7.7/csharp-runtime.html
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

antlr-tool.noarch: W: spelling-error Summary(en_US) ANother -> Another, Anther,
An other
The value of this tag appears to be misspelled. Please double-check.

antlr-tool.noarch: W: spelling-error %description -l en_US recognizers ->
recognizer, recognizes, recognize rs
The value of this tag appears to be misspelled. Please double-check.

antlr-tool.noarch: W: spelling-error %description -l en_US parsers -> parser,
parses, parers
The value of this tag appears to be misspelled. Please double-check.

antlr-tool.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/antlr-tool-2.7.7/LICENSE.txt
This file has wrong end-of-line encoding, usually caused by creation or
modification on a non-Unix system. It could prevent it from being displayed
correctly in some circumstances.

antlr-tool.noarch: W: devel-file-in-non-devel-package /usr/bin/antlr-config
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

4 packages and 0 specfiles checked; 1 errors, 63 warnings.


If there is any documentation that could be put in the C++ subpackage, please
do so.  What about the .hpp files?  I assume there's a good reason they're not
in a -devel package, but it should be commented on in the spec.  Please fix the
permissions in the docs as well as the encoding issue.



Otherwise, everything looks great.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.