[Bug 587087] Review Request: Spawning - A HTTP server for hosting WSGI python web applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=587087

Terje Røsten <terjeros at phys.ntnu.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Terje Røsten <terjeros at phys.ntnu.no> 2010-04-29 16:49:18 EDT ---
! rpmlint

 Spawning.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/spawning/spawning_controller.py 0644
/usr/bin/env
 Spawning.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/spawning/spawning_child.py 0644 /usr/bin/env

Easy to fix with a sed oneliner.

ok naming of package and spec
ok spec file
  might add %global rver 0.9.3rc2 to use in Source0 and %setup?
  more explicit in %files might be good:
 %{python_sitelib}/*
ok license approved and tag ok. MIT, all files have headers. Good.
ok license in %doc
ok correct language
ok sha1sum on sources and ok url
   sha1sum Spawning-0.9.3rc2.tar.gz*
    7a5b07fb51692f13e9787f631c09782861073856  Spawning-0.9.3rc2.tar.gz
    7a5b07fb51692f13e9787f631c09782861073856  Spawning-0.9.3rc2.tar.gz.spec
  might download with wget -N  to get correct timestamp on tarball 
ok koji build with correct buildreq, see comment #1
ok excludearch
 - locale files 
 - ldconfig
ok no bundling
ok owns, dirs and perms and only once
ok macros
ok code or content
 - large docs
ok %doc not affect the runtime
 - headers|static in devel|static
 - .so in devel
 - devel dep on base
 - no .la|.a file
 - gui with desktop file
ok own just not owned
ok utf-8 file names

ok separate file from upstream
ok trans
ok mock/koji
   see comment #1
ok testing
 - scriptlets sane
 - subpkgs dep on base
 - pkgconfig(.pc) in devel
 - req on package not on files
ok add man pages


There are some init scripts in rc-scripts, those are not written for
Fedora it seems. However, they still have some value. Include as %doc?
If you have better init scripts available, include those.

Nothing major here, consider the points over when importing.


 The package Spawning is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.