[Bug 585707] Review Request: guayadeque - Music player based on wxWidgets

bugzilla at redhat.com bugzilla at redhat.com
Fri Apr 30 05:53:12 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585707

--- Comment #3 from Mohammed Imran <imranceh at gmail.com> 2010-04-30 01:53:12 EDT ---
I'm also learning,We're in the Same Boat Brother ;)

Few more things to fix 

rpmlint output
===============
[imran at localhost SPECS]$ rpmlint guayadeque.spec
../SRPMS/guayadeque-0.2.5-1.fc11.src.rpm
../RPMS/i586/guayadeque-0.2.5-1.fc11.i586.rpm
guayadeque.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
guayadeque.src: E: description-line-too-long Music Player with the aims to be
intuitive, easy to use and fast even for huge music collections. Developed for
Linux with wxWidgets for GTK under Gnome.
guayadeque.src: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
guayadeque.i586: E: description-line-too-long Music Player with the aims to be
intuitive, easy to use and fast even for huge music collections. Developed for
Linux with wxWidgets for GTK under Gnome.
2 packages and 1 specfiles checked; 2 errors, 2 warnings.

* Please refer
https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#description-line-too-long

* Run rpmlint on both the SRPM and the binary RPMs before uploading them for
review

* Increase the "Release" tag every time you upload a new package to avoid
confusion. The reviewer and other interested parties probably still have older
versions of your SRPM lying around to check what has changed between the old
and new packages; those get confused when the revision didn't change.Also
change revision number in changelog tag as 0.2.5-2

* No . at the end of summary 

Apart from these,spec looks ok to me. 

Also refer this URL
http://fedoraproject.org/wiki/Koji

For scratch build on koji use command
koji build --scratch dist-f14 <SRPM_file>

Best of luck :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list