[Bug 581131] Review Request: circuslinux - Gameplay is similar to "Breakout" and "Arkanoid"

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581131

--- Comment #4 from Mohammed Imran <imranceh at gmail.com> 2010-04-30 09:41:39 EDT ---
Let me do a informal review

Need to fix these
==================

1) change Url: to URL(optional)
2) Please change Description entirely,explain the game,dont use trademarks 
http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description
3) change Exec in .desktop file to %{name} and Categories to Game;
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
4) desktop-file-install should be used in %install section
Also Validate the desktop entry,add below lines
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop
5)fix `/usr/share/doc/circuslinux-1.0.3': Permission denied
in mkinstalldirs script in %install section
6) use %{SOURCE5} instead of %SOURCE5

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  rpmlint should be run on each and every RPM
[x]  Package is named according to the Package Naming Guidelines.
http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description
[x]  Spec file name must match the base package %{name}, in the format
%{name}.spec.

[!]  Package meets the Packaging Guidelines.
should not use Atari or "based on some company" in description 
please refer 
http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description

[!]  Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Need to fix ./mkinstalldirs,cant write /usr/share/doc/circuslinux-version dir
error

[x]  Package is not relocatable.
[x]  Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x]  License field in the package spec file matches the actual license.
License type:GPLv2

[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]  Spec file is legible and written in American English.
[!]  Sources used to build the package matches the upstream source, as provided
in the spec URL.

MD5SUM this package    :b699f3fb94a5855697d0c0667c977ac2
MD5SUM upstream package:d53f7d28d974c5605d6bebb9b1569216 
Use pristine sources

[x]  Package is not known to require ExcludeArch, OR:
Arches excluded:
Why:
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.

[-]  The spec file handles locales properly.
[-]  ldconfig called in %post and %postun if required.
[-]  Package must own all directories that it creates.
[-]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly. 
[x]  Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x]  Package consistently uses macros.
[x]  Package contains code, or permissable content.
[-]  Large documentation files are in a -doc subpackage, if required.
[x]  Package uses nothing in %doc for runtime.
[-]  Header files in -devel subpackage, if present.
[-]  Static libraries in -devel subpackage, if present.
[-]  Package requires pkgconfig, if .pc files are present.
[-]  Development .so files in -devel subpackage, if present.
[-]  Fully versioned dependency in subpackages, if present.
[x]  Package does not contain any libtool archives (.la).

[!]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
Catergories should be Game;
Categories=Game;
Exec should be just %{name}

[x]  Package does not own files or directories owned by other packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.