[Bug 619928] Review Request: tigase-server - Tigase XMPP Server in Java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619928

--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk> 2010-08-02 03:55:09 EDT ---
* Package correctly named
* License OK, allowed in Fedora, full text included
* Versioned accordance with guidelines
* VCS snapshot provided, revision number ok, correctly commented
* BuildRequires seem complete
** Mock build not attempted since I'm too lazy to inject tigase-utils =]
** Local rebuild succeeded
* Prebuilt stuff dropped
* Spec file clean and legible, American English used
* Filelists sane
* Requires/Provides ok

1.) RPMlint

I find all of these worth addressing:

tigase-server.noarch: E: zero-length /etc/tigase/database/derby-create-db.sql
tigase-server.noarch: E: incoherent-logrotate-file /etc/logrotate.d/tigase
Your logrotate file should be named /etc/logrotate.d/<package name>.

tigase-server.noarch: W: no-reload-entry /etc/rc.d/init.d/tigase
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

2.) Why is this needed?

export LANG=en_US

Please comment if it is necessary. Rpmbuilds sets lang to C already:

$ rpm --eval %___build_pre |grep LANG
  LANG=C
  export LANG

This is pending import of tigase-utils and resolution of rpmlint warnings

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.