[Bug 619831] Review Request: ltl2ba - Fast translation from LTL formulas to Büchi automata

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619831

--- Comment #2 from Mark Rader <msrader at gmail.com> 2010-08-02 07:21:00 EDT ---
Initial Comments:

Need to correct spelling/fonts in the Spec File.  Büchi is probably the
correct spelling but it uses fonts that do not display well and can cause
issues.

MUST: rpmlint must be run on every package. The output should be posted in the
review.

(Done)

MUST: The package must be named according to the Package Naming Guidelines .

(Ok)

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.

(Ok) 

MUST: The package must meet the Packaging Guidelines .

(Ok)

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .

(Ok)

MUST: The License field in the package spec file must match the actual license. 

(Ok)

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]

MUST: The spec file must be written in American English. [5]
(Issue, contains non english characters)

MUST: The spec file for the package MUST be legible. [6]
(Issue, contails non ascii characters)

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
(Ok)

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
(Unknown Koji Build is needed)

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
(Unknown Koji Build is needed)

MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
(Unknown Koji Build is needed)

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]

MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
(Ok)

MUST: Packages must NOT bundle copies of system libraries.[11]
(Ok)


MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.
(Ok)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.