[Bug 619383] Review Request: gsettings-desktop-schemas - A collection of GSettings schemas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619383

--- Comment #4 from Tomáš Bžatek <tbzatek at redhat.com> 2010-08-02 08:12:11 EDT ---
(In reply to comment #3)
> Some notes:
> 
> * EVR
>   - For versioning, please use "0.0.1-Y.gitXXXXXXXX%{?dist}"
>     as described in the below (this versioning method is much
>     safer)
>    
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Post-Release_packages
Fixed.

> * BuildRoot
>   - is no longer used on Fedora (EPEL5 and below still uses, however I
>     don't think this package will be imported there)
>     https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Removed.

> * noarch handling
>   - Maybe you want to use "%configure --libdir=%{_datadir}".
I decided to move particular files manually since this a young gnome package
and things might change a lot in the future, including some files to libdir (a
change from noarch package will be needed naturally).

> * Timestamps
>   - Please consider to use
> -----------------------------------------------------------------------
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
> -----------------------------------------------------------------------
>     to keep timestamps on installed files as much as possible.
>     This method usually works on Makefiles generated by recent
>     autotools.
Changed.

> * %clean
>   - %clean section is no longer needed on Fedora 13 and above
>     https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
>     (and I think this pakage is needed only for F-14+).
Removed.

> * %postun, %posttrans
>   - Maybe this is better?
>     http://lists.fedoraproject.org/pipermail/packaging/2010-May/007065.html
>     (I don't know the current status of packaging guideline proposal
>     about gsettings)
Oh yes, this looks better.

>     By the way Requires(postun) or so is needed for this?
Added a global glib2 require, not sure if I need to explicitly add postun
require.

> * Directory ownership issue
>   - %{_datadir}/glib-2.0/schemas/ is owned by glib2 and
>     it seems "Requires: glib2 (>= 2.25.x)" is needed for main
>     package.    
Same as above.

Wow, so many things in packaging guidelines changed since my last package
submission. 

As a result of these changes, rpmlint now throws few more warnings, which can
be safely ignored:
gsettings-desktop-schemas.src: W: no-cleaning-of-buildroot %clean
gsettings-desktop-schemas.src: W: no-buildroot-tag
gsettings-desktop-schemas.src: W: no-%clean-section


Updated files:
Spec URL:
http://tbzatek.fedorapeople.org/gsettings-desktop-schemas/gsettings-desktop-schemas.spec
SRPM URL:
http://tbzatek.fedorapeople.org/gsettings-desktop-schemas/gsettings-desktop-schemas-0.0.1-1.git20100729.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.