[Bug 619437] Review Request: bm - Rpm package building helper

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 2 12:36:50 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619437

--- Comment #9 from Terje Røsten <terjeros at phys.ntnu.no> 2010-08-02 08:36:48 EDT ---
> Modified the package this time following the fedora python package guide.
> Here's the koji entry
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2373182

Thanks. Better, however still som issues

 - please post direct links to updates spec and srpm, this make it much simpler
to review your package
 - python_sitearch macro is not used and should be dropped
 - I don't understand why recompiling pyc files are needed, seems to work fine
without
 - the recipe for getting the sources must be more explicit, it must be
possible
   to redo the source tarball down to the same bits, that means using a
revision
   number from svn repo. See 
   https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
   for more information.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list