[Bug 617942] Review Request: geronimo-saaj - Java EE: SOAP with Attachments API Package v1.3

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617942

--- Comment #2 from Chris Spike <chris.spike at arcor.de> 2010-08-02 08:57:31 EDT ---
(In reply to comment #1)
> NEEDSWORK: The License field in the package spec file must match the actual
> license.
> 
> I am sorry I haven't noticed this when I was doing
> osgi-support...LICENSE file has 2 licenses, but 2nd license only
> applies to non-existant file (XMLSchema.dtd). Therefore:
>  * spec file should only have ASL 2.0 as a license
>  * upstream should be contacted so that they can fix the issue
> 
> I didn't check for existence of that file while doing osgi-support
> review (my bad).

Fixed.

No problem. I noticed it too, but didn't ask further questions in the
osgi-support review. Fixed it there, too.

> NEEDSWORK: Each package must consistently use macros.
> 
> again that bug in rpmstubby...rm in one place %{__rm} in another one...

Fixed.


New spec and SRPM:
http://spike.fedorapeople.org/geronimo-saaj/geronimo-saaj.spec
http://spike.fedorapeople.org/geronimo-saaj/geronimo-saaj-1.1-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.