[Bug 616779] Review Request: rubygem-json_pure - JSON implementation in pure Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=616779

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-08-02 11:24:57 EDT ---
For -2:

* BuildRoot
  - So I still see that you put BuildRoot tag in your spec file.
    Are you going to import this package also for EPEL?
    - Note that currently ruby-gtk2 is not available on EPEL.

* BuildRequires
  - Would you check if "BR: ruby-"devel"" is needed?

* Removing files in %check
  - Modifying or removing files should not be done in %check
    (%check section is for checking).
    Please move the line
-----------------------------------------------------------------
rm -rf %{buildroot}/%{geminstdir}/ext
-----------------------------------------------------------------
    to %install.

* Document files
-----------------------------------------------------------------
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
-----------------------------------------------------------------
  - These are not documents and please move these two to
    main package.

  - License texts or so should be included in main package.
    Please move below to main package.
----------------------------------------------------------------
%doc %{geminstdir}/README
%doc %{geminstdir}/GPL
%doc %{geminstdir}/COPYING
%doc %{geminstdir}/CHANGES
%doc %{geminstdir}/VERSION
%doc %{geminstdir}/TODO
----------------------------------------------------------------

  - On the other hand, I think "%{geminstdir}/install.rb" can be
    moved into -doc subpackage.

  - Now rpmlint warns:
----------------------------------------------------------------
rubygem-json_pure-doc.noarch: W: doc-file-dependency
/usr/lib/ruby/gems/1.8/gems/json_pure-1.4.3/benchmarks/generator_benchmark.rb
/usr/bin/env
rubygem-json_pure-doc.noarch: W: doc-file-dependency
/usr/lib/ruby/gems/1.8/gems/json_pure-1.4.3/tests/test_json_encoding.rb
/usr/bin/env
rubygem-json_pure-doc.noarch: W: doc-file-dependency
/usr/lib/ruby/gems/1.8/gems/json_pure-1.4.3/tools/server.rb /usr/bin/env
rubygem-json_pure-doc.noarch: W: doc-file-dependency
/usr/lib/ruby/gems/1.8/gems/json_pure-1.4.3/benchmarks/parser_benchmark.rb
/usr/bin/env
rubygem-json_pure-doc.noarch: W: doc-file-dependency
/usr/lib/ruby/gems/1.8/gems/json_pure-1.4.3/tests/test_json_fixtures.rb
/usr/bin/env
rubygem-json_pure-doc.noarch: W: doc-file-dependency
/usr/lib/ruby/gems/1.8/gems/json_pure-1.4.3/tests/test_json_rails.rb
/usr/bin/env
----------------------------------------------------------------
    These warnings can be removed by either
    - Removing %doc from %files entry in -doc subpackage
      (I don't think that explicitly writing %doc attribute in -doc
      subpackage is needed, because the name of the rpm already
      shows that the rpm is for documentation)
    - Or removing shebangs and removing executable permission.

* Directory ownership issue
  - "%dir %{geminstdir}" in -doc subpackage is unneeded because main
    package already owns this directory (and -doc depends on main
    package).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.