[Bug 620738] Review Request: snoopy - A preload library to send shell commands to syslog

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620738

Darryl L. Pierce <dpierce at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Darryl L. Pierce <dpierce at redhat.com> 2010-08-04 08:24:48 EDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > MUST: Every binary RPM package (or subpackage) which stores shared library
> > files (not just symlinks) in any of the dynamic linker's default paths, must
> > call ldconfig in %post and %postun. [10]
> > 
> > Not done. And there is no %postun section.
> > 
> > Please address this last piece.   
> 
> Yes of course:
> 
> 
> Spec URL: http://scern.ch/straylen/rpms/snoopy/snoopy.spec
> SRPM URL: http://cern.ch/straylen/rpms/snoopy/snoopy-1.6.1-2.el5.src.rpm    

Final changes:

1. Please remove the code to add and remove entries to /etc/ld.so.preload. On
Fedora installing a package should not change default behavior like this.
Instead, provide instructions to the admin for how to preload the library.

2. Both %post and %postun need to call ldconfig. Please see:

http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

With those changes, I'll approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.