[Bug 618451] Review Request: gdb-heap - Extensions to gdb for debugging dynamic memory allocation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618451

Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tcallawa at redhat.com
               Flag|                            |fedora-review?

--- Comment #16 from Tom "spot" Callaway <tcallawa at redhat.com> 2010-08-04 09:14:55 EDT ---
A few points:

The comment at the top is no longer valid, but there is still no reason to
create debuginfo here (it would be empty), as this is a architecture indepedent
payload in an arch specific package (to match glibc). It would be nice to
update that comment to reflect the actual reason for disabling debuginfo.

Also, the license tag is still invalid (should be LGPLv2+ and Python). Plus,
you don't include copies of the License text. Given that you're upstream on
this, you must do this (and package them as %doc). You should also do a proper
header attribution of LGPLv2+ in your source files (with the exception of the
Python licensed file(s), of course), like this:

    Copyright (C) <year>  <name of author>

    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
    License as published by the Free Software Foundation; either
    version 2.1 of the License, or (at your option) any later version.

    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
    Lesser General Public License for more details.

    You should have received a copy of the GNU Lesser General Public
    License along with this library; if not, write to the Free Software
    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

Last, rpmlint says:

gdb-heap.src:47: W: macro-in-comment %{_isa}
gdb-heap.src:47: W: macro-in-comment %{glibc_version}

Should be harmless, but I would still advise that you %% out those macros in
the comments.

=== REVIEW ===

MUST FIX:

- rpmlint checks return:
gdb-heap.src: W: invalid-license PSF
gdb-heap.x86_64: W: invalid-license PSF
License tag must be fixed before import, as described above.
- license (LGPLv2+ and Python) OKAY, but texts missing and files poorly
attributed, see above.

Good:

- rpmlint checks return:
gdb-heap.src:47: W: macro-in-comment %{_isa}
gdb-heap.src:47: W: macro-in-comment %{glibc_version}
gdb-heap.x86_64: E: no-binary

Macros in comments should be cleaned up.

- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Clean up those MUSTFIX items and I can approve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.