[Bug 619257] Review Request: rubygem-stomp - Ruby client for the Stomp messaging protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619257

--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-08-04 13:31:05 EDT ---
For -2:

* BR style
  - Please unify to "BuildRequires: rubygem(rspec)" style.

* BR
  - "BR: rubygem(rake)" is needed (otherwise rake spec cannot
    be executed)

* %defattr
  - Please set %defattr on -doc subpackage.
  ! By the way I usually think that %doc attribute on -doc subpackage
    is redundant because its rpm name already indicates that this rpm
    is for documentation.

* Documentation
  - License related files should be in main package.
    Please move the following files to main.
----------------------------------------------------------
%{geminstdir}/CHANGELOG.rdoc
%{geminstdir}/LICENSE
%{geminstdir}/README.rdoc
----------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.