[Bug 601577] Review Request: lockfile - This library implements a number of functions found in -lmail on SysV systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601577

--- Comment #16 from Matthias Runge <mrunge at matthias-runge.de> 2010-08-05 03:00:42 EDT ---
(In reply to comment #15)
> (In reply to comment #14)
> > After a minimal change (creating %{_lib}/debug in buildroot), lockfile builds
> > fine in koji.
> 
> I guess the build error came from this line in the devel subpackage files
> section:
> %exclude %{_libdir}/debug/
I'm not sure about this. Those two lines from koji build.log:
extracting debug info from
/builddir/build/BUILDROOT/lockfile-1.08-5.fc13.x86_64/usr/bin/dotlockfile
symlinked /usr/lib/debug/usr/lib64/liblockfile.so.1.0.debug to
/usr/lib/debug/usr/lib64/liblockfile.so.debug

look some strange to me. I could not figure out, why this happens. Anyway, it's
fixed in actual version.

> 
> Why is it there in the first place?
> 
It's removed now; in an older version of this package was debuginfo included in
a hidden path.

> Also the file COPYRIGHT needs to be included in both packages (the main package
> and the devel subpackage) since a recent policy change.

fixed.

> 
> Why do you do this in %install:
> ln -s %{_libdir}/liblockfile.so.1.0 %{buildroot}/%{_libdir}/liblockfile.so
> ln -s %{_libdir}/liblockfile.so.1.0 %{buildroot}/%{_libdir}/liblockfile.so.1
> 
> and remove at least one of these commands from Makefile.in in %prep?
> liblockfile.so.\$(VER) \$(ROOT)\$(libdir)\/liblockfile.so//" Makefile.in
> file.in in %prep?    
In Makefile.in is only one link included. I tried to keep them both together.
Another solution would change Makefile to include the corresponding other link.
Do you think, it's should go there?

diff -u:
--- lockfile.spec-5 2010-08-05 08:36:31.000000000 +0200
+++ lockfile.spec 2010-08-05 08:55:46.000000000 +0200
@@ -1,6 +1,6 @@
 Name:           lockfile
 Version:        1.08
-Release:        5%{?dist}
+Release:        6%{?dist}
 Summary:        This implements a number of functions found in -lmail on SysV
systems

 Group:          Applications/System
@@ -33,6 +33,7 @@
 # remove -g root from install
 sed -i "s/install -g root -m 755 dotlockfile \$(ROOT)\$(bindir);/install -m
755 dotlockfile \$(ROOT)\$(bindir);/" Makefile.in

+# remove link-creation from Makefile (to be done later during install)
 sed -i "s/ln -s liblockfile.so.\$(VER) \$(ROOT)\$(libdir)\/liblockfile.so//"
Makefile.in

 %build
@@ -49,6 +50,8 @@
 %{__mkdir} -p %{buildroot}/%{_mandir}/man1
 %{__mkdir} -p %{buildroot}/%{_mandir}/man3
 make ROOT=%{buildroot} install_shared
+
+# create links for ldconfig
 ln -s %{_libdir}/liblockfile.so.1.0 %{buildroot}/%{_libdir}/liblockfile.so
 ln -s %{_libdir}/liblockfile.so.1.0 %{buildroot}/%{_libdir}/liblockfile.so.1

@@ -75,10 +78,11 @@
 %doc COPYRIGHT 


-
 %changelog
 * Thu Aug 5 2010 Matthias Runge <mrunge at matthias-runge.de> 1.08-6
+- include COPYRIGHT in -devel, too
+- remove unnecessary exclude
+
 * Tue Aug 3 2010 Matthias Runge <mrunge at matthias-runge.de> 1.08-5
 - fix shared lib warning, sort lib to devel

Fixed versions are:
SPEC: http://www.matthias-runge.de/fedora/lockfile.spec
SRPM: http://www.matthias-runge.de/fedora/lockfile-1.08-6.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.