[Bug 226457] Merge Review: system-config-httpd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226457

--- Comment #5 from Parag AN(पराग) <panemade at gmail.com> 2010-08-05 03:28:47 EDT ---
Review:
+ package builds on koji (f14).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2380714
+ rpmlint output for SRPM and for RPM.
system-config-httpd.src: W: invalid-url URL:
http://hg.fedoraproject.org/hg/system-config-httpd/ <urlopen error [Errno -2]
Name or service not known>
system-config-httpd.src: W: no-cleaning-of-buildroot %install
system-config-httpd.src: W: invalid-url Source0:
system-config-httpd-1.5.3.tar.gz
system-config-httpd.noarch: E: explicit-lib-dependency libglade2
system-config-httpd.noarch: W: incoherent-version-in-changelog 1.5.3-1
['5:1.5.3-1.fc14', '5:1.5.3-1']
system-config-httpd.noarch: W: invalid-url URL:
http://hg.fedoraproject.org/hg/system-config-httpd/ <urlopen error [Errno -2]
Name or service not known>
system-config-httpd.noarch: E: non-readable
/etc/alchemist/namespace/system-config-httpd/rpm.adl 0600L
system-config-httpd.noarch: W: non-conffile-in-etc
/etc/alchemist/namespace/system-config-httpd/rpm.adl
system-config-httpd.noarch: E: non-readable
/etc/alchemist/switchboard/system-config-httpd.switchboard.adl 0600L
system-config-httpd.noarch: W: non-conffile-in-etc
/etc/alchemist/switchboard/system-config-httpd.switchboard.adl
system-config-httpd.noarch: E: non-readable
/etc/alchemist/namespace/system-config-httpd/local.adl 0600L
system-config-httpd.noarch: W: dangerous-command-in-%preun rm
2 packages and 0 specfiles checked; 4 errors, 8 warnings.


Suggestions:
1) If this package is needed to be built for F-13 and above then please follow
  a) buildroot tag should be removed
  b) %clean section is not needed

2) You don't need to write BR: and R: for python >= 2.2
   See https://fedoraproject.org/wiki/Packaging/Python
   Add BR: python2-devel only

3) Can you please tell me what is usage of %{_datadir}/kontrol-panel ?

4) rpmlint messages
system-config-httpd.noarch: E: non-readable
/etc/alchemist/namespace/system-config-httpd/rpm.adl 0600L
system-config-httpd.noarch: W: non-conffile-in-etc
/etc/alchemist/namespace/system-config-httpd/rpm.adl
system-config-httpd.noarch: E: non-readable
/etc/alchemist/switchboard/system-config-httpd.switchboard.adl 0600L
system-config-httpd.noarch: W: non-conffile-in-etc
/etc/alchemist/switchboard/system-config-httpd.switchboard.adl
system-config-httpd.noarch: E: non-readable
/etc/alchemist/namespace/system-config-httpd/local.adl 0600L
==> I think comment should be added in spec file if these files needed to keep
600 permissions.

5) Currently unable to create source tarball

hg clone http://hg.fedoraproject.org/hg/system-config-httpd/
=> abort: error: Name or service not known

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.