[Bug 590573] Review Request: cuneiform - OCR System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590573

--- Comment #7 from Peter Lemenkov <lemenkov at gmail.com> 2010-08-05 04:43:37 EDT ---
* It seems that it can't be built on PowerPC

http://koji.fedoraproject.org/koji/taskinfo?taskID=2380960 (F-12)

Otherwise it build fine on x86 and x86_64
http://koji.fedoraproject.org/koji/taskinfo?taskID=2380967 (F-13).

Please, add the following line into your spec:

ExclusiveArch:  %{ix86} x86_64

* Also you need to add license.txt to %doc. Interestingly, but upstream ships 3
license.txt files - two of them are identical. while the other one (bundled
with crash report utility) is different:

Sulaco ~/rpmbuild/BUILD/cuneiform-linux-1.0.0: find -type f -iname "license*"
-print -exec md5sum {} \;
./cuneiform_src/Addfiles/license.txt
62227db15001fcdcf2cbe3eb05fec860  ./cuneiform_src/Addfiles/license.txt
./cuneiform_src/Kern/icrashreport/sources/crashrpt/src/license.txt
0662a916b38fe8b1093b17cfc3f521b6 
./cuneiform_src/Kern/icrashreport/sources/crashrpt/src/license.txt
./cuneiform_src/Kern/license.txt
62227db15001fcdcf2cbe3eb05fec860  ./cuneiform_src/Kern/license.txt
Sulaco ~/rpmbuild/BUILD/cuneiform-linux-1.0.0: 

* You need to split off development-related files, namely:

work ~/Desktop: rpm -qp cuneiform-1.0.0-1.fc13.i686.rpm -l | grep -E
\(include\|so$\)
/usr/include/cuneiform.h
/usr/lib/libccom.so
/usr/lib/libced.so
/usr/lib/libcfcompat.so
/usr/lib/libcfio.so
/usr/lib/libcimage.so
/usr/lib/libcline.so
/usr/lib/libcpage.so
/usr/lib/libcpu32.so
/usr/lib/libcstr.so
/usr/lib/libctb32.so
/usr/lib/libcuneiform.so
/usr/lib/libdif32.so
/usr/lib/libevn32.so
/usr/lib/libexc.so
/usr/lib/libfon32.so
/usr/lib/libleo32.so
/usr/lib/liblns32.so
/usr/lib/libloc32.so
/usr/lib/libmmx32.so
/usr/lib/libmsk32.so
/usr/lib/libpass2.so
/usr/lib/libr3532.so
/usr/lib/librbal.so
/usr/lib/librblock.so
/usr/lib/librcorrkegl.so
/usr/lib/librcutp.so
/usr/lib/librdib.so
/usr/lib/librfrmt.so
/usr/lib/librimage.so
/usr/lib/librline.so
/usr/lib/librling.so
/usr/lib/librlings.so
/usr/lib/librmarker.so
/usr/lib/librneg.so
/usr/lib/librout.so
/usr/lib/librpic.so
/usr/lib/librpstr.so
/usr/lib/librreccom.so
/usr/lib/librsadd.so
/usr/lib/librselstr.so
/usr/lib/librshelllines.so
/usr/lib/librstr.so
/usr/lib/librstuff.so
/usr/lib/librverline.so
/usr/lib/libsmetric.so
/usr/lib/libstd32.so
work ~/Desktop:

* Since you're installing libraries into %{_libdir} you need to add proper
post/postun scriptlets:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

* No such rpm group - Office/Productivity. Most closest equivalent is
Applications/Productivity. See /usr/share/doc/rpm-*/GROUPS for full list.

* rpmlint warns about weird behavior of several shared libraries:

cuneiform.i686: W: shared-lib-calls-exit /usr/lib/librfrmt.so.1.0.0
exit at GLIBC_2.0
cuneiform.i686: W: shared-lib-calls-exit /usr/lib/libstd32.so.1.0.0
exit at GLIBC_2.0
cuneiform.i686: W: shared-lib-calls-exit /usr/lib/liblns32.so.1.0.0
exit at GLIBC_2.0

This should (should, not must) be reported upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.