[Bug 612998] Review Request: PyPAM - PAM bindings for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612998

--- Comment #5 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-08-05 07:09:59 EDT ---
Actually I believe those BRs/Rs are not correct still. You have BR on
python3-devel when on Fedora 13, but you don't re-define __python variable to
point to python 3. See
https://fedoraproject.org/wiki/Packaging:Python#Bytecompiling_with_the_correct_python_version

This is however moot, because I checked and upstream doesn't support Python3 at
all (I checked and it really doesn't work). Your spec file had BR on
python3-devel but still used python2 to compile/install the package and because
of that, it worked.

So just have simple BR on python2-devel (no if-defs). I guess I should have
been more clear about those BRs (python2 vs python3) when I started the
official review. Sorry about that.

Other than that package is OK now, so I'll approve once you fix those Python
BRs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.