[Bug 226457] Merge Review: system-config-httpd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226457

--- Comment #6 from Phil Knirsch <pknirsch at redhat.com> 2010-08-05 08:17:30 EDT ---

(In reply to comment #5)
> Review:
> + package builds on koji (f14).
> koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2380714
> + rpmlint output for SRPM and for RPM.
> system-config-httpd.src: W: invalid-url URL:
> http://hg.fedoraproject.org/hg/system-config-httpd/ <urlopen error [Errno -2]
> Name or service not known>

Doh, my mistake, i had a buggy line in the specfile. Fixed.

> system-config-httpd.src: W: no-cleaning-of-buildroot %install

According to http://fedoraproject.org/wiki/Packaging/Guidelines#tags this isn't
necessary anymore:

  BuildRoot tag

Fedora (as of F-10) does not require the presence of the BuildRoot tag in the
spec and if one is defined it will be ignored. The provided buildroot will
automatically be cleaned before commands in %install are called. 

Therefore i left it like it is.

> system-config-httpd.src: W: invalid-url Source0:
> system-config-httpd-1.5.3.tar.gz

See comment above Source0 how to create the tarball.

> system-config-httpd.noarch: E: explicit-lib-dependency libglade2

Ah: pygtk2-libglade requires libglade-2.0.so.0()(64bit) which is provided by
libglade2, so i've dropped the requirement as it should be properly pulled in
via the pygtk2-libglade package. Fixed.

> system-config-httpd.noarch: W: incoherent-version-in-changelog 1.5.3-1
> ['5:1.5.3-1.fc14', '5:1.5.3-1']
> system-config-httpd.noarch: W: invalid-url URL:
> http://hg.fedoraproject.org/hg/system-config-httpd/ <urlopen error [Errno -2]
> Name or service not known>

See above, fixed.

> system-config-httpd.noarch: E: non-readable
> /etc/alchemist/namespace/system-config-httpd/rpm.adl 0600L
> system-config-httpd.noarch: W: non-conffile-in-etc
> /etc/alchemist/namespace/system-config-httpd/rpm.adl
> system-config-httpd.noarch: E: non-readable
> /etc/alchemist/switchboard/system-config-httpd.switchboard.adl 0600L
> system-config-httpd.noarch: W: non-conffile-in-etc
> /etc/alchemist/switchboard/system-config-httpd.switchboard.adl
> system-config-httpd.noarch: E: non-readable
> /etc/alchemist/namespace/system-config-httpd/local.adl 0600L
> system-config-httpd.noarch: W: dangerous-command-in-%preun rm
> 2 packages and 0 specfiles checked; 4 errors, 8 warnings.
> 
> 
> Suggestions:
> 1) If this package is needed to be built for F-13 and above then please follow
>   a) buildroot tag should be removed
>   b) %clean section is not needed
> 

Both removed now.

> 2) You don't need to write BR: and R: for python >= 2.2
>    See https://fedoraproject.org/wiki/Packaging/Python
>    Add BR: python2-devel only
> 

Also fixed those.

> 3) Can you please tell me what is usage of %{_datadir}/kontrol-panel ?
> 

Erh, odd. That shouldn't be there. Removed aka fixed, too.

> 4) rpmlint messages
> system-config-httpd.noarch: E: non-readable
> /etc/alchemist/namespace/system-config-httpd/rpm.adl 0600L
> system-config-httpd.noarch: W: non-conffile-in-etc
> /etc/alchemist/namespace/system-config-httpd/rpm.adl
> system-config-httpd.noarch: E: non-readable
> /etc/alchemist/switchboard/system-config-httpd.switchboard.adl 0600L
> system-config-httpd.noarch: W: non-conffile-in-etc
> /etc/alchemist/switchboard/system-config-httpd.switchboard.adl
> system-config-httpd.noarch: E: non-readable
> /etc/alchemist/namespace/system-config-httpd/local.adl 0600L
> ==> I think comment should be added in spec file if these files needed to keep
> 600 permissions.
> 

Added a comment now above the respective lines:

# This file is not supposed to be read by users, only root, so 0600 permission.

> 5) Currently unable to create source tarball
> 
> hg clone http://hg.fedoraproject.org/hg/system-config-httpd/
> => abort: error: Name or service not known    

Aye, see at the start: hg.fedoraproject.org doesn't exist anymore, it's now
called hg.fedorahosted.org. I've fixed all the occurrences of the URL already.

New srpm here:
http://pknirsch.fedorapeople.org/src/system-config-httpd-1.5.4-1.el6.src.rpm

Thanks & regards, Phil

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.