[Bug 611328] Review Request: hydra - Fast login cracker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611328

--- Comment #4 from Michael Schwendt <mschwendt at gmail.com> 2010-08-07 10:34:52 EDT ---
Whether to use %{name} or the expanded "hydra" is completely irrelevant here.
Using %{name} makes sense in places where you expect the package name to change
and you'd like to reuse spec file fragments.

Nowadays, it's fine to use such macros in the "SourceX" tags, because tools
like spectool (from package "rpmdevtools") can expand them when downloading
remote files. See e.g.: spectool -g hydra.spec

It's also perfectly fine not to use macros in the "PatchX" tags. "Patch1:
hydra-5.7-nosvnapr.patch" refers to a file with exactly that name. And while
the package %{name} might change, there is no implicit/automatic renaming of
the patch files. You don't win anything by over-using macros.

To apply patches with -p1 is very common, too.

Whether to start with Patch0 or Patch1 is no issue at all, provided that the
numbers for the "Patch" tags match the "%patch" commands. That is, avoid using
the unnumbered "Patch: foo.patch" tag.
It's widely common for heavily patched packages to remove obsolete patches,
too, from time to time. And if you don't close the gaps in the resulting
numbering, such spec files don't start with Patch0.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.