[Bug 620990] Review Request: itools - Command line tools for The Islamic Tools and Libraries Project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620990

--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-08-07 12:27:19 EDT ---
Well,

* -3 doesn't build
  http://koji.fedoraproject.org/koji/taskinfo?taskID=2387135

* Using %{name}, %{version} in source URL is preferred. ref:
  https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* BuildRoot
  - Again on Fedora (and EPEL6) BuildRoot tag is no longer needed.
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* Parallel make support
  - You seem to have removed parallel make support, but unless there is
    a reason please don't remove it.
    https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.