[Bug 606205] Review Request: halberd - Tool to discover HTTP load balancers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606205

Rafael Aquini <aquini at linux.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Rafael Aquini <aquini at linux.com> 2010-08-07 13:51:33 EDT ---
Good:
* The package is named halberd which follows upstream project name
* Spec file naming follows package naming
* License in spec and sources is GPLv2+ which is open source
* Spec is legible and American English
* http://halberd.superadditive.com/dist/halberd-0.2.3.tar.gz
* Source matches upstream
* No locale files
* No shared libraries
* No bundled libraries
* Not relocatable
* No directories created unowned
* No duplicate files
* Default permissions are set
* Package is code
* No large documentation
* No %doc files are used at runtime
* No header files
* Not a GUI application
* Does not own files or directories from other packages
* All filenames are utf8
* rpmlint is clean:
[aquini at optiplex ~]$ rpmlint rpmbuild/SPECS/halberd.spec
rpmbuild/SRPMS/halberd-0.2.3-2.fc13.src.rpm
rpmbuild/RPMS/noarch/halberd-0.2.3-2.fc13.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

* Builds in mock 
* Builsd in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2387255 

Needswork:
* Ask upstream a patch to fix the following deprecation warning, when halberd
is executed:
[aquini at optiplex ~]$ halberd http://aquini.fedorapeople.org/
/usr/lib/python2.6/site-packages/Halberd/clues/Clue.py:33: DeprecationWarning:
the sha module is deprecated; use the hashlib module instead
  from sha import new as hashfn
halberd 0.2.3 (18-Jul-2007)

INFO looking up host aquini.fedorapeople.org... 


Regards

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.