[Bug 620990] Review Request: itools - Command line tools for The Islamic Tools and Libraries Project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620990

--- Comment #11 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-08-07 15:28:20 EDT ---
Okay, more two things (I overlooked previously...)

* Timestamps
-------------------------------------------------------------
install -m 644 doc/* $RPM_BUILD_ROOT%{_mandir}/man1
-------------------------------------------------------------
  - Please add "-p" option for install command to keep timestamps
    on installed files:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

* %changelog
-------------------------------------------------------------
* Sat Aug 07 2010 Tajidin Abd <tajidinabd at archlinux.us> itools-1.0-5
-------------------------------------------------------------
  - Remove redundant "itools-" part. ref:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.