[Bug 591900] Review Request: libcapifax - Support for Sending/receiving faxes over CAPI capable devices

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 7 20:35:09 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591900

--- Comment #11 from Felix Kaechele <felix at fetzig.org> 2010-08-07 16:35:08 EDT ---
Sorry, I was busy last week again.
I see that you removed the %clean section completely. It's required however and
does require a rm -rf %{buildroot} also your changelog includes the info that
the rm -rf %{buildroot} has moved from %build to %install. %install however
does not contain rm -rf %{buildroot} (as it should).
Seems that there was a little misunderstanding regarding that.

Other than that everything else seems fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list