[Bug 567028] Review Request: lv2-ll-plugins - Collection of LV2 plugins

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567028

--- Comment #8 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-08-08 22:35:28 EDT ---
Hello, sorry I was too busy in the past week with the python-2.7 rebuilds for
Fedora 14.

(In reply to comment #7)
> There are a few issues to address.
> 
> Here is the output of rpmlint:
> lv2-ll-plugins.src: W: spelling-error %description -l en_US arpeggiator ->
> arpeggiate, arpeggio, appoggiatura
> lv2-ll-plugins.src:39: W: configure-without-libdir-spec
> lv2-ll-plugins.x86_64: W: spelling-error %description -l en_US arpeggiator ->
> arpeggiate, arpeggio, appoggiatura
> lv2-ll-plugins.x86_64: W: no-manual-page-for-binary elven
> /home/makerpm/rpmbuild/SPECS/lv2-ll-plugins.spec:39: W:
> configure-without-libdir-spec
> 
> Spelling is fine.  I suppose we could file a bug against the words package if
> we wanted to be helpful, but that isn't necessary.
> 
> You should email upstream about a man page.
> 

I talked to upstream about elven. Apparently, elven became a separate project:
   http://gitorious.org/elven/elven

The next release of the ll plugins will not include elven. I should probably
drop elven from our RPM. What do you think?

> I understand that configure isn't generated by autotools, but I am not sure
> you couldn't specify libdir instead of specifying lv2plugindir.  It looks like
> lv2plugindir will be set to $(libdir)/lv2 by default, so why not just set
> libdir?  Am I missing something?
> 

Well, we can do it either way. It really doesn't matter. This is more of a
convention. I don't think this should be a blocker.

> Since the elven package is capable of displaying some plugins with guis, should
> there be .desktop files for it to start the included gui plugins?
> 

See above about dropping elven. But I don't think we should include a .desktop
file. If we do, we need to supply a .desktop file for every lv2 plugin we ship.
And this means that the elven package needs to be updated whenever some
lv2-X-plugins package gets included in Fedora. This sounds impractical.

> This package needs to Require: lv2core for directory ownership.    

Ah good catch. I will add this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.