[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents
bugzilla at redhat.com
bugzilla at redhat.com
Mon Aug 9 09:19:59 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621898
--- Comment #3 from Chen Lei <supercyper1 at gmail.com> 2010-08-09 05:19:57 EDT ---
Some suggestions:
1.Provides: wbxml2 = %{version}-%{release} is not useful since no rpm is
actually depends wbxml2 explicitly.
2.
BuildRequires: cmake, expat-devel, perl
Requires: libxml2-devel, pkgconfig
rpmbuild will add pkgconfig as a dependency automatically[1], perl is on the
exception list of Buildrequires[2](There is no need to include the following
packages or their dependencies as BuildRequires).
[1]http://fedoraproject.org/wiki/PackagingGuidelines#Pkgconfig_Files
[2]http://fedoraproject.org/wiki/PackagingGuidelines#Exceptions_2
3.
%build
# Upstream does not support in-source-directory building
SRCDIR="$PWD"
%define builddir ../build
rm -rf %{builddir}
mkdir %{builddir}
cd %{builddir}
%cmake "$SRCDIR"
make %{?_smp_mflags}
->
%build
mkdir -p %{_target_platform}
pushd %{_target_platform}
%{cmake} ..
popd
make %{?_smp_mflags} -C %{_target_platform}
%install
rm -rf %{buildroot}
make install/fast DESTDIR=%{buildroot} -C %{_target_platform}
See http://fedoraproject.org/wiki/SIGs/KDE, this is also suggested as the next
version cmake packaging guideline in Fedora.
4.
%files devel
%defattr(-,root,root,-)
%doc AUTHORS BUGS ChangeLog COPYING GNU-LGPL NEWS README References THANKS TODO
You should not try to add duplicate docs to -devel, rpmlint warnings can be
safely ignored.
5.
%files
%{_libdir}/libwbxml2.so.0*
->
%{_libdir}/libwbxml2.so.*
If upstream bumps soname, you don't need to modify %files again.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list