[Bug 621017] Review Request: rubygem-scruffy - A powerful, clean graphing library for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621017

--- Comment #2 from Mohammed Morsi <mmorsi at redhat.com> 2010-08-10 18:37:18 EDT ---
(In reply to comment #1)
> Some notes:
> 
> * Unused macros
>   - Defined %ruby_sitelib macro seems used nowhere

Removed

> 
> * License
> -------------------------------------------------------------
> CC-BY
> ./website/javascripts/lightbox.js
> 
> LGPLv2+
> ./website/javascripts/rounded_corners_lite.inc.js
> -------------------------------------------------------------
>   - License tag should be "MIT and CC-BY and LGPLv2+"
>     (also see below)

Since these files have been added to the docs package, these additional
licenses have only been applied to that.

> 
> * Requires
>   - "R: ruby(abi) = 1.8" is a must item.
>   - "rubygem(hoe)" is for development dependency (for
>     Rakefile) and is not needed for runtime
>     (Also "hoe" is marked as "s.add_development_dependency"
>     in installed .gemspec file)

Changed to a BR(check) dependency.


>   - lib/scruffy.rb contains:
> ------------------------------------------------------------
>     17  require 'rubygems'
>     18  gem 'builder', '>= 2.0'
>     19  require 'builder'
> ------------------------------------------------------------
>     So this package should have "Requires: rubygem(builder)".

Added.

> 
> * Documents
>   - I guess the following files / directories can be
>     moved to -doc subpackage (after creating -doc subpackage).
>     Would you consider this?
> ----------------------------------------------------------
> %{geminstdir}/Rakefile
> %{geminstdir}/config
> %{geminstdir}/script
> %{geminstdir}/spec
> %{geminstdir}/test
> %{geminstdir}/website
> %{geminstdir}/tasks
> %{geminstdir}/setup.rb
> %{gemdir}/doc/%{gemname}-%{version}
> ----------------------------------------------------------

Done

> 
> * %check
>   - As this gem contains spec/ and test/ directories, please
>     add %check section and execute some test programs
>     ($ rake test and $ rake spec) there.    

Done.

Updated:
Spec URL: http://mo.morsi.org/files/gems/rubygem-scruffy.spec
SRPM URL: http://mo.morsi.org/files/gems/rubygem-scruffy-0.2.6-2.fc13.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2392215

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.