[Bug 617405] Review Request: poezio - An IRC-like jabber (XMPP) console client

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 11 10:07:45 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617405

--- Comment #6 from Florent Le Coz <louiz at louiz.org> 2010-08-11 06:07:44 EDT ---
Thank you for the review, a and sorry to have been impatient. :)

Spec File: http://louizatakk.fedorapeople.org/rpm/poezio.spec
SRPM File: http://louizatakk.fedorapeople.org/rpm/poezio-0.6.2-3.fc13.src.rpm

(In reply to comment #5)
> 
> Some minor issues. None of them is really important, this more meant to be a
> little education for Tom.
> 
> Please change the %global at the beginning of the spec as per
> https://fedoraproject.org/wiki/Packaging:Python#Macros
> 
DONE

> 
> Please don't use articles like "A" or "An" in the summary, just "IRC-like
> jabber (XMPP) console client" is fine.
> 
DONE

> 
> mkdir -p %{buildroot}%{_datadir}/%{name}
> mkdir -p %{buildroot}%{_datadir}/%{name}/data
> mkdir -p %{buildroot}%{_datadir}/%{name}/src
> 
> at least the first line is not necessary. The whole thing could be boiled down
> to
> 
> mkdir -p %{buildroot}%{_datadir}/%{name}/{data,src}
>
DONE
(It is now
mkdir -p %{buildroot}%{_datadir}/%{name}/data
mkdir -p %{buildroot}%{_datadir}/%{name}/src
For readability)

> 
> Please preserve timestamps during %install with install -p, see
> https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
> 
DONE

> 
> Also preserve the timestamps when removing the shebangs from files, see
> https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries
> 
> 
DONE

> Instead of 
> 
> %{_datadir}/%{name}
> 
> better use the 
> 
> %{_datadir}/%{name}/
> The trailing / is to indicate it is a directory and not a file. This doesn't
> make a difference to rpm, but helps other humans to read the spec.
>
DONE

> For the launcher I'd rather use:
> 
> # create launcher
> cat > %{buildroot}%{_bindir}/%{name} <<EOF
> #!/usr/bin/env sh
> cd %{_datadir}/poezio/src/ && python poezio.py
> EOF
> 
DONE

> None of these things really is a blocker. Please apply the changes (or at least
> the ones that you think are useful) and consider the package APPROVED.    
Ok, thank you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list