[Bug 611454] Review Request: python-bcrypt - Python bindings for OpenBSD's Blowfish password hashing code

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 11 10:59:30 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611454

--- Comment #9 from Mohammed Safwat <Mohammed_ElAfifi at yahoo.com> 2010-08-11 06:59:29 EDT ---
I've checked the recent package files and they've really been updated to
resolve the issues I posted earlier. Thanks for the effort to address these
remarks.

There's still one point pending regarding the changelog remark; the changelog
entries you added don't conform to any of the three formulas imposed by
http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs. You should edit
these entries to conform to one of them. One tool you might find useful in
creating future changelog(whenever you make changes to the package later) is
rpmdev-bumpsepc, you can read about a brief usage to this tool at
http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Helpful_tools.

While waiting for approving your package, you can do other reviews to speed up
the process of sponsoring you. Please check
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored#Reviewing_Packages
to know ways of getting yourself sponsored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list