[Bug 427484] Review Request: publican-RedHat - Red Hat theme

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=427484

Nick Bebout <nb at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #15 from Nick Bebout <nb at fedoraproject.org> 2010-08-11 19:20:07 EDT ---
[nb at sanjose01 SPECS]$ rpmlint publican-redhat.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[nb at sanjose01 SRPMS]$ rpmlint publican-redhat-2.0-2.fc13.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[nb at sanjose01 SOURCES]$ sha1sum publican-redhat-2.0.tgz 
9568e41e868fbf507777ed841e2cbc46ae7c4cae  publican-redhat-2.0.tgz
[nb at sanjose01 SOURCES]$ sha1sum publican-redhat-2.0.tgz.1
9568e41e868fbf507777ed841e2cbc46ae7c4cae  publican-redhat-2.0.tgz.1

[YES] specfiles match
[YES] source files match upstream
[YES] package meets naming and versioning guidelines.
[YES] spec is properly named, cleanly written, and uses macros consistently.
[YES] dist tag is present.
[YES] build root is correct.
[YES] license field matches the actual license.
[YES] license is open source-compatible.
[YES] license text included in package.
[YES] latest version is being packaged.
[YES] BuildRequires are proper.
[YES] compiler flags are appropriate.
[YES] %clean is present. 
[YES] package builds in mock.
[YES] package installs properly.
[N/A] debuginfo package looks complete.
[YES] rpmlint is silent.
[YES] final provides and requires are sane
[N/A] %check is present and all tests pass:
[YES] no shared libraries are added to the regular linker search paths.
[YES] owns the directories it creates. 
[YES] doesn't own any directories it shouldn't.
[YES] no duplicates in %files.
[YES] file permissions are appropriate.
[YES] scriptlets match those on ScriptletSnippets page.
[YES] code, not content.
[YES] documentation is small, so no -docs subpackage is necessary.
[YES] %docs are not necessary for the proper functioning of the package.
[YES] no headers.
[YES] no pkgconfig files.
[YES] no libtool .la droppings.
[N/A] desktop files valid and installed properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.