[Bug 601115] Review Request: lockfile-progs - safely lock and unlock files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601115

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #6 from Martin Gieseking <martin.gieseking at uos.de> 2010-08-13 17:16:38 EDT ---
Here are some more quick comments:

- replace "make" with 
  make %{_smp_mflags} CFLAGS='%{optflags}'
  and move it to the %build section

- in order to ensure that symbolic links are created, add 
  sed -i 's/\(cd bin && ln \)/\1 -sf /' Makefile
  before the call of make (or patch the Makefile appropriately)

- I suggest to replace %{__mkdir} and %{__cp} with plain mkdir and cp, 
  respectively

- add COPYING as %doc

- be more specific when adding the man pages:
  %{_mandir}/man1/*.1*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.