[Bug 601115] Review Request: lockfile-progs - safely lock and unlock files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601115

--- Comment #9 from Matthias Runge <mrunge at matthias-runge.de> 2010-08-14 15:19:21 EDT ---
Thank you for your remarks. I took them and changed the spec according to them.

[mrunge at sofja SPECS]$ diff -u lockfile-progs.spec.orig lockfile-progs.spec
--- lockfile-progs.spec.orig 2010-08-14 19:18:37.095702770 +0200
+++ lockfile-progs.spec 2010-08-14 21:10:13.654660407 +0200
@@ -1,6 +1,6 @@
 Name:           lockfile-progs
 Version:        0.1.15
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Command-line programs to safely lock and unlock files and
mailboxes

 License:        GPLv2
@@ -18,17 +18,20 @@

 %prep
 %setup -q -n sid
+sed -i 's/\(cd bin && ln \)/\1 -sf /' Makefile

 %build
+make %{_smp_mflags} CFLAGS='%{optflags}'

+%check
+make check

 %install
 rm -rf %{buildroot}
-make 
-%{__mkdir} -p %{buildroot}/%{_bindir}
-%{__cp} -r --preserve=all bin/* %{buildroot}/%{_bindir}
-%{__mkdir} -p %{buildroot}/%{_mandir}/man1
-%{__cp} -r --preserve=all man/* %{buildroot}/%{_mandir}/man1/
+mkdir -p %{buildroot}/%{_bindir}
+cp -r --preserve=all bin/* %{buildroot}/%{_bindir}
+mkdir -p %{buildroot}/%{_mandir}/man1
+cp -r --preserve=all man/* %{buildroot}/%{_mandir}/man1/

 %clean
 rm -rf %{buildroot}
@@ -42,10 +45,15 @@
 %{_bindir}/mail-lock
 %{_bindir}/mail-touchlock
 %{_bindir}/mail-unlock
-%{_mandir}/man?/*
-
+%{_mandir}/man1/*.1*
+%doc COPYING

 %changelog
+* Sat Aug 14 2010 Matthias Runge <mrunge at matthias-runge.de> 0.1.15-2
+- correct make-invocation, move it to build
+- COPYING in as doc
+- remove {__-invocations, replace by plain calls
+
 * Fri Aug 13 2010 Matthias Runge <mrunge at matthias-runge.de> 0.1.15-1
 - new version from upstream


new updated SPEC and SRPM:
SPEC: http://www.matthias-runge.de/fedora/lockfile-progs.spec
SRPM: http://www.matthias-runge.de/fedora/lockfile-progs-0.1.15-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.