[Bug 610842] Review Request: meego-panel-devices - Meego devices panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=610842

Sebastian Dziallas <sebastian at when.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Sebastian Dziallas <sebastian at when.com> 2010-08-18 16:04:19 EDT ---
This looks good, with two issues remaining. Please fix the license tag and
rpmlint before importing. APPROVED.

[  OK  ] specfiles match: 7af3d5c10d57d00f21faeeffc62c8c01
[  OK  ] source files match upstream: 397f5e6892ef95fa526abb392c1ccc63
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  NO  ] license field matches the actual license.

I think you actually want LGPLv2 instead of LGPLv2+ in the license tag.

[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  OK  ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[  OK  ] debuginfo package looks complete.
[  NO  ] rpmlint is silent.

meego-panel-devices.i686: W: non-conffile-in-etc
/etc/xdg/autostart/meego-power-icon.desktop
meego-panel-devices.i686: W: non-conffile-in-etc
/etc/gconf/schemas/meego-panel-devices.schemas

[  OK  ] final provides and requires are sane
[  NA  ] %check is present and all tests pass:
[  OK  ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  NA  ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  NA  ] desktop files valid and installed properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.