[Bug 226315] Merge Review: prelink

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226315

--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-08-18 17:41:59 EDT ---
Ugh, chromium messed up on me. The correct patch is in comment #5. What I have
done in the patch is:
- modernized buildroot tag (you can as well remove it altogether, if you like)
- moved testing to %check
- made the %install section a bit clearer (if you don't this changes, just
scrap it)
- added missing documentation to %doc
- switched to using %{_bindir} and %{_sbindir} macros
- fixed macros in comments.

Since the makefile is missing the DESTDIR target, looks like makeinstall needs
to be used for now. However, as you are upstream, I'm sure you could fix this
in a jiffy.

What still needs to be done is the source URL - the "we are upstream" exception
was removed from the Packaging Guidelines a while ago. Please ask for a project
for prelink on fedorahosted.org and make the stuff available there.

Once you have done this I can safely approve this review.


PS. Maybe you'll want to add license headers to the test suite, too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.