[Bug 619395] Review Request: mozc - Opensourced Google Japanese Input
bugzilla at redhat.com
bugzilla at redhat.com
Thu Aug 19 19:24:08 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=619395
--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-08-19 15:24:07 EDT ---
Some notes for 0.12.434.102-0.1.20100817svn
* License
- So the license for dictionary/ directory is
* mecab-ipadic (for mecab-ipadic)
* BSD (for mecab-naist-jdic)
? If so, "mecab-ipadic" should also be added into license tag
(note that "mecab-ipadic" is already registered in
http://fedoraproject.org/wiki/Licensing )
* BuildRoot
- BuildRoot tag is no longer needed (no longer used) on
Fedora 10+ and EPEL6:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
? Obsoletes
- I don't understand why "Obsoletes: ibus-mozc < 0.11.383.102" is added
to main package although mozc has not existed on Fedora.
* optflags / make build.log more verbose / debuginfo rpm
- Currently build.log shows the output like:
---------------------------------------------------------------
208 + python build_mozc.py build_tools -c Release
209 ACTION base_gen_version_def
out_linux/Release/obj/gen/base/version_def.cc
210 ACTION base_gen_character_set
out_linux/Release/obj/gen/base/character_set.h
211 CXX(target)
out_linux/Release/obj.target/storage/storage/existence_filter.o
212 CXX(target)
out_linux/Release/obj.target/storage/storage/lru_storage.o
213 CXX(target) out_linux/Release/obj.target/storage/storage/registry.o
214 CXX(target)
out_linux/Release/obj.target/storage/storage/tiny_storage.o
---------------------------------------------------------------
With these messages we cannot check if optflags are correctly honored
during
build.
- Also currently debuginfo rpm does not contain needed source files:
--------------------------------------------------------------
mozc-debuginfo.i686: E: debuginfo-without-sources
--------------------------------------------------------------
This usually means that optflags are not correctly honored (especially "-g"
flag), or binaries are stripped during build or install.
- So please make build.log more verbose so that we can check if Fedora
specific
compilation flags are correctly honored.
? %clean
- Why is it needed to call "python build_mozc.py clean" after build?
(Note that %_builddir%{?buildsubdir} is deleted after build anyway)
* %defattr
- Please set %defattr also for subpackages.
! ppc64 build failure
- By the way your srpm fails to build on F-12 ppc64. It seems that segfault
is
occuring.
----------------------------------------------------------------
/bin/sh: line 1: 8168 Segmentation fault
../mozc_build_tools/linux/gen_connection_data_main --logtostderr
"--input=../data/dictionary/connection.txt" --make_header
"--output=/builddir/build/BUILD/mozc-0.12.434.102/out_linux/Release/obj/gen/converter/embedded_connection_data.h"
make: *** [out_linux/Release/obj/gen/converter/embedded_connection_data.h]
Error 139
make: *** Waiting for unfinished jobs....
----------------------------------------------------------------
http://koji.fedoraproject.org/koji/taskinfo?taskID=2412449
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list