[Bug 619395] Review Request: mozc - Opensourced Google Japanese Input

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619395

--- Comment #7 from Akira TAGOH <tagoh at redhat.com> 2010-08-20 03:21:09 EDT ---
(In reply to comment #6)
> * License
>   - So the license for dictionary/ directory is
>     * mecab-ipadic (for mecab-ipadic)
>     * BSD (for mecab-naist-jdic)
>     ? If so, "mecab-ipadic" should also be added into license tag
>     (note that "mecab-ipadic" is already registered in
>     http://fedoraproject.org/wiki/Licensing )

I should added that. fixed.

> * BuildRoot
>   - BuildRoot tag is no longer needed (no longer used) on 
>     Fedora 10+ and EPEL6:
>     https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

fixed.

> ? Obsoletes
>   - I don't understand why "Obsoletes: ibus-mozc < 0.11.383.102" is added
>     to main package although mozc has not existed on Fedora.

not for official one but to fix the package changes on local repo for testing.

> 
> * optflags / make build.log more verbose / debuginfo rpm

Okay, fixed in gyp.

> ? %clean
>   - Why is it needed to call "python build_mozc.py clean" after build?
>     (Note that %_builddir%{?buildsubdir} is deleted after build anyway)

fixed.

> * %defattr
>   - Please set %defattr also for subpackages.

Doh. fixed.

> ! ppc64 build failure
>   - By the way your srpm fails to build on F-12 ppc64. It seems that segfault
> is
>     occuring.
> ----------------------------------------------------------------
> /bin/sh: line 1:  8168 Segmentation fault     
> ../mozc_build_tools/linux/gen_connection_data_main --logtostderr
> "--input=../data/dictionary/connection.txt" --make_header
> "--output=/builddir/build/BUILD/mozc-0.12.434.102/out_linux/Release/obj/gen/converter/embedded_connection_data.h"
> make: *** [out_linux/Release/obj/gen/converter/embedded_connection_data.h]
> Error 139
> make: *** Waiting for unfinished jobs....
> ----------------------------------------------------------------
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=2412449

Sure. will have a look though, that may be a bit hard to investigate a kinda
issue if there are no debugging machine.. just for snapshot of fixes:

Spec URL: http://tagoh.fedorapeople.org/reviews/mozc/mozc.spec
SRPM URL:
http://tagoh.fedorapeople.org/reviews/mozc/mozc-0.12.434.102-0.1.20100820svn.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.