[Bug 476530] Review Request: projxp - Agile project management server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476530

--- Comment #11 from Rafael Aquini <aquini at linux.com> 2010-08-20 14:31:21 EDT ---
Darryl,

Please, consider the following review:


Good:
* Package is named projxp which follows the upstream project name
* Spec file naming follows package naming
* License in sources and spec is GPLv3 which is open source
* License text included in the tarball and listed on %file.
* Spec is legible and American English
* No locale files
* No shared libraries
* No bundled libraries
* Not relocatable
* Default permissions are set
* Macros used consistently 
* Package is code
* No large documentation
* No header files
* No static libraries
* Not a GUI application
* Does not own files or directories from other packages
* All filenames are utf8
* Builds in mock (see needswork [3], though)

NEEDSWORK:
[1] rpmlint complaints:
    $ rpmlint SPECS/projxp.spec SRPMS/projxp-0.3.0-1.fc13.src.rpm
RPMS/noarch/projxp-0.3.0-1.fc13.noarch.rpm 
SPECS/projxp.spec:87: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab:
line 87)
    projxp.src:87: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line
87)
    projxp.noarch: W: non-standard-uid /var/log/projxp projxp
    projxp.noarch: W: non-standard-gid /var/log/projxp projxp
    projxp.noarch: W: non-standard-uid /var/log/projxp/mongrel.log projxp
    projxp.noarch: W: non-standard-gid /var/log/projxp/mongrel.log projxp
    projxp.noarch: W: non-standard-uid /var/log/projxp/rails.log projxp
    projxp.noarch: W: non-standard-gid /var/log/projxp/rails.log projxp
    projxp.noarch: W: non-standard-uid /var/run/projxp projxp
    projxp.noarch: W: non-standard-gid /var/run/projxp projxp
    2 packages and 1 specfiles checked; 0 errors, 10 warnings.


[2] Source within SRPM **does not** match upstream:
    * http://mcpierce.fedorapeople.org/projxp-0.3.0.tgz
    $ md5sum SOURCES/projxp-0.3.0/projxp-0.3.0.tgz
../Downloads/projxp-0.3.0.tgz 
    bdceb1aeb1df37a06138f93b4e0958f9  SOURCES/projxp-0.3.0/projxp-0.3.0.tgz
    1fddf9be4dcd35e1e2a6478935db43df  ../Downloads/projxp-0.3.0.tgz


[3] Package builds with duplicate file warnings:
    Processing files: projxp-0.3.0-1.fc13.noarch
    warning: File listed twice: /usr/share/projxp/doc/AUTHORS
    warning: File listed twice: /usr/share/projxp/doc/Backlog
    warning: File listed twice: /usr/share/projxp/doc/COPYING
    warning: File listed twice: /usr/share/projxp/doc/Contributing
    warning: File listed twice: /usr/share/projxp/doc/INSTALL
    warning: File listed twice: /usr/share/projxp/doc/LICENSE


[4] Directory /var/projxp, which is HOMEDIR for projxp user, is not created
neighter it is owned by the package. See 
https://fedoraproject.org/wiki/Packaging:UsersAndGroups for further reference.
Also, /var is supposed to contain variable data files and logs.


[5] Your package should contain man pages for the scripts / configs / usage.



Regards

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.