[Bug 626446] Review Request: libmutil - A C++ library providing various utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=626446

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de> 2010-08-24 03:15:41 EDT ---
Hi Peter, here are some quick comments:

- File %{_datadir}/aclocal/winfuncs.m4 is licensed under GPLv2+. This should
  be reflected in the License tag of the devel package (LGPLv2+ and GPLv2+).

- I recommend to replace %{_includedir}/* with %{_includedir}/%{name}/

- The folder %{_datadir}/%{name}/examples/ contains sample source code and
  should probably be added with %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.