[Bug 598511] Review Request: libgtextutils - Assaf Gordon text utilities

bugzilla at redhat.com bugzilla at redhat.com
Tue Aug 24 16:32:03 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598511

--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-08-24 12:32:02 EDT ---
Oh, so you have made release 2? Ugh.

Anyway, the issues still remain.

**

Overriding the compilation flags is, of course, the cleaner solution to making
sure the right flags are used. However, setting CFLAGS is not enough, also
CXXFLAGS needs to be set, so use

make %{?_smp_mflags} CFLAGS="%{optflags}" CXXFLAGS="%{optflags}"

(or, if you decide to go with the other macro syntax, use $RPM_OPT_FLAGS
instead of %{optflags})

**

Some headers are installed, so you might want to consider saving their time
stamps in %install with

 make install INSTALL="install -p"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list