[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625678

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-08-25 04:57:00 EDT ---
Review:
+ Koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2425290 is
successful.
+ rpmlint is output for SRPM and for RPM.
ghostscript-chinese.noarch: W: self-obsoletion cjkuni-fonts-ghostscript
obsoletes cjkuni-fonts-ghostscript = 0.2.20080216.1
ghostscript-chinese.src:24: W: unversioned-explicit-obsoletes
cjkuni-fonts-ghostscript
ghostscript-chinese.src: W: no-cleaning-of-buildroot %install
ghostscript-chinese.src: W: no-cleaning-of-buildroot %clean
ghostscript-chinese.src: W: no-buildroot-tag
ghostscript-chinese.src: W: no-%clean-section
ghostscript-chinese-zh_CN.noarch: W: no-documentation
ghostscript-chinese-zh_TW.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 8 warnings.


+ source files match upstream url (sha1sum)
a1192e567ab75e614e1292109cdae74470356b8d  ghostscript-chinese-0.3.1.tar.gz
a1192e567ab75e614e1292109cdae74470356b8d  ghostscript-chinese-0.3.1.tar.gz.srpm
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ Macro use appears rather consistent.
+ no translations are available
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.

Suggestions:
1) Please see
https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Subpackage_Licensing.
According to it, subpackages should require main package as it installs
COPYING.

you can drop main package installing subpackages if not needed.

2) I think ghostscript is already above 8.63-4 version in Fedora so you can
drop versioned requires for ghostscript and just have 
Requires: ghostscript

3) rpmlint showed self-obsoletion. See
http://fedoraproject.org/wiki/PackageNamingGuidelines#Renaming.2Freplacing_existing_packages
This can be fixed by using

Provides:     cjkuni-fonts-ghostscript = %{version}
Obsoletes:    cjkuni-fonts-ghostscript < 0.2.20080216.1


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.