[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529278

Andrew Overholt <overholt at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |overholt at redhat.com
               Flag|                            |fedora-review?

--- Comment #15 from Andrew Overholt <overholt at redhat.com> 2010-08-25 20:04:32 EDT ---
Sorry it's taken me so long to get back to this, Orion.  Things actually look
pretty good and I'm very impressed with the cleanliness of the .spec for this
monster package!  I'm building on top of the rawhide packages (Helios stuff)
and get this build error in the org.eclipse.ptp.pldt.openmp.analysis plugin:

87. ERROR in
/home/overholt/rpmbuild/BUILD/org.eclipse.ptp-v201004302110/tools/org.eclipse.ptp.pldt.openmp.analysis/src/org/eclipse/ptp/pldt/openmp/analysis/PAST/PASTPragma.java
(at line 22)
        public class PASTPragma extends PASTNode implements
IASTPreprocessorPragmaStatement
                     ^^^^^^^^^^
The type PASTPragma must implement the inherited abstract method
IASTPreprocessorPragmaStatement.isPragmaOperator()

Have you seen this before?

My only comment on the .spec is that the %descriptions are kind of long.  I
presume you just generated these from the feature files?  I agree with the
rpmlint reasons you give above (although I haven't re-examined its output since
it doesn't build for me ATM).

I'll go through the rest of the packaging guidelines but things seem alright. 
You can probably bump the release to 1 since this version of PTP was presumably
released with Helios in June.

Again, apologies for taking so long to get back to this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.