[Bug 593800] Review Request: python-keyring - keyring module for python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593800

--- Comment #25 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-08-26 14:47:55 EDT ---
At least please address the issues I mentioned before.

(In reply to comment #18)
> Some notes:
> 
> * Macro definition
>   - For defining %python_sitearch macro and so on, please follow
>     below:
>     https://fedoraproject.org/wiki/Packaging/Python#Macros
> 
> * Filtering Provides
>   - If you want to filter some Provides generated by rpmbuild,
>     you can now use "%filter_provides_in" macro as defined in
>     /usr/lib/rpm/redhat/macro (in redhat-rpm-config rpm):
>    
> https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_provides_.28pre-scan_filtering.29

  ! And still the current way of yours does not work as you expected, see:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2429162
    http://koji.fedoraproject.org/koji/getfile?taskID=2429162&name=build.log

> * python-devel BuildRequires:
>   - Now please explicitly specify python2-devel or python3-devel for
>     (Build)Requires:
>     https://fedoraproject.org/wiki/Packaging/Python#BuildRequires
> 
> * KDE BuildRequires
>   - This packge uses Qt4, so only KDE4 should be needed.
>     Please write "BR: kdelibs4-devel" only and remove "BR: kdelibs3-devel".
>     ! Note
>       - Unfortunately, it seems that the needed "libkdeui.so" (for -lkdeui) is
>         under %_libdir/kde4/devel (in kdelibs-devel), so you have to
>         add "export LDFLAGS=-L%{_libdir}/kde/devel" or something else
>         before "python setup.py build".


* duplicate files entry
  - Now build.log complains:
----------------------------------------------------------------------
warning: File listed twice:
/usr/lib64/python2.7/site-packages/keyring/__init__.py
warning: File listed twice:
/usr/lib64/python2.7/site-packages/keyring/__init__.pyc
warning: File listed twice:
/usr/lib64/python2.7/site-packages/keyring/__init__.pyo
warning: File listed twice:
/usr/lib64/python2.7/site-packages/keyring/backend.py
warning: File listed twice:
/usr/lib64/python2.7/site-packages/keyring/backend.pyc
warning: File listed twice:
/usr/lib64/python2.7/site-packages/keyring/backend.pyo
warning: File listed twice: /usr/lib64/python2.7/site-packages/keyring/core.py
warning: File listed twice: /usr/lib64/python2.7/site-packages/keyring/core.pyc
warning: File listed twice: /usr/lib64/python2.7/site-packages/keyring/core.pyo
----------------------------------------------------------------------
    Note that the %files entry
----------------------------------------------------------------------
%files
%{python_sitearch}/%{upstream_name}
----------------------------------------------------------------------
    contains the directory %{python_sitearch}/%{upstream_name} itself
    and all files / directories / etc under this directory, while
----------------------------------------------------------------------
%files
%dir %{python_sitearch}/%{upstream_name}
----------------------------------------------------------------------
    contains the directory %{python_sitearch}/%{upstream_name} only.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.