[Bug 614036] Review Request: stdair - C++ Standard Airline IT Library - FE-NEEDSPONSOR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614036

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de> 2010-08-28 03:49:07 EDT ---
Here are some more comments:

- the package doesn't build in mock because of missing 
  BuildRequires:soci-mysql-devel

- The tarball bundles library libextracppunit. It's not permitted to link
  against bundled libraries in Fedora. Instead, remove it and use the
  corresponding library provided by a separate package. extracc isn't part of
  Fedora yet, but already under review (bug #616881).
  Also see https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

- replace %define with %global
 
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define 

- As far as I see, there are no info files. Hence, drop Requires(post) and
  Requires(preun).

- since you can't add any new packages to Fedora < 12, remove the %if 
  statements. It's sufficient to use the following for all targets: 
  BuildArch:      noarch
  BuildRequires:  tex(latex)

- it's not necessary to remove INSTALL in %prep

- I recommend to replace
    rm -f $RPM_BUILD_ROOT%{_libdir}/lib%{name}.la
    rm -f $RPM_BUILD_ROOT%{_libdir}/libextracppunit.la
    rm -rf %{mydocs} && mkdir -p %{mydocs}
  with
    rm -f $RPM_BUILD_ROOT%{_libdir}/*.la
    mkdir -p %{mydocs}

  (you don't need to remove %{mydocs} as it doesn't exist here yet)

- move the man3 manpages to the devel package as it contains information for
  developers

- drop AUTHORS, ChangeLog, NEWS, and README from the doc package
  (files must not be added multiple times, COPYING is an exception here)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.