[Bug 627637] Review Request: qroneko - A front end of crontab application
bugzilla at redhat.com
bugzilla at redhat.com
Sun Aug 29 09:13:55 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=627637
Martin Gieseking <martin.gieseking at uos.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.gieseking at uos.de
--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de> 2010-08-29 05:13:54 EDT ---
Hi Praveen,
the tarball in the SRPM doesn't match the upstream one:
$ md5sum qroneko-0.5.4.tar.gz*
e223113fb16e96d6780da3d29eb4c214 qroneko-0.5.4.tar.gz
5e2e20d9ce40e076cbe79d64a21f6e6b qroneko-0.5.4.tar.gz.1
You must use the unchanged upstream tarball to build you package. Also, don't
add a file containing the license text if it's not present in the tarball.
However, you should ask the upstream developer to add it to a future release.
If you need to change some source files, add patches to your package.
Here are some more comments:
- Drop BR: qt as it's automatically added as a dependency of qt-devel.
- I suggest to use the %description text from the upstream website:
qroneko is a scheduling utility which uses crontab as the backend.
Features and highlights:
* Smart "Cron Time" Setting.
* Lists expected execute time.
* Enables to edit crontab by text
- In the %prep section, it's sufficient to use %setup -q
- Don't add full paths to install and qmake_qt4 since they may be different.
Just use "install" and %{_qt4_qmake}
- The tarball doesn't contain a .desktop file. Thus, you have to add one to
your package. See https://fedoraproject.org/wiki/Packaging/Guidelines#desktop
(permissions of the .desktop file should be 0644)
- add a blank line between the %changelog entries to increase legibility
- The package fails building for x86_64. The Compilation aborts with error
messages like this:
CronModel.cpp:248: error: cast from 'TCommand*' to 'int' loses precision
This should be reported and fixed upstream. However, the upstream
developer submitted the latest changes 4 years ago, so the project probably
isn't active any longer.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list